-
Notifications
You must be signed in to change notification settings - Fork 168
chore(deps): update dependency gradle to v8.13 #1766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1f37cb3 to
50798ff
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
|
@LikeTheSalad @zeitlinger |
disk-buffering/build.gradle.kts
Outdated
| } | ||
|
|
||
| val protoVersion = "1.5.0" | ||
| val protoArchive = layout.buildDirectory.file("archives/opentelemetry-proto-$protoVersion.zip").get().asFile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @laurit! Although I think it's better if we don't have to rely on third-party plugins. I was checking and I think we could make it work by replacing the wire block with the following changes, wdyt?
val wireDependencies =
configurations.detachedConfiguration(project.dependencies.create("io.opentelemetry.proto:opentelemetry-proto:1.5.0-alpha"))
wireDependencies.setTransitive(false)
val wireSrcDirCollector = tasks.register("wireSrcJarCollect", Sync::class) {
from(provider {
wireDependencies.map {
zipTree(it).matching {
setIncludes(listOf("**/*.proto"))
}
}
})
into(layout.buildDirectory.dir("protos/opentelemetry-proto"))
}
wire {
java {}
sourcePath {
srcDir(wireSrcDirCollector)
}
root(
"opentelemetry.proto.trace.v1.TracesData",
"opentelemetry.proto.metrics.v1.MetricsData",
"opentelemetry.proto.logs.v1.LogsData",
)
}There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the dependency on the download task. If you believe further changes are needed create a PR. We can merge that PR and recreate this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. If the build passes, I'm ok with leaving it as is. Though if there are further issues, I'll create a separate PR, as you suggest, to sort them out.
This PR contains the following updates:
8.12.1->8.13Release Notes
gradle/gradle (gradle)
v8.13Compare Source
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.